Align NIC workflow states with Symphony orchestration profile#4
Open
Align NIC workflow states with Symphony orchestration profile#4
Conversation
- Add /dashboard route with query parameter support for v2 interface - Implement tabbed navigation (Overview, Issues, Metrics) - Add clickable issue table with detail page views - Support deep linking: /dashboard?v=2&tab=issues&issueId=NIC-xxx - Enhanced CSS styling for v2 while maintaining v1 compatibility - Add slide-in animations and responsive mobile design
- Add alert detection logic to Presenter for capacity, rate limits, and orchestrator health - Implement alerts panel UI in both v1 and v2 dashboards - Support warning/critical severity levels with color coding - Include specific remediation guidance for each alert type - Graceful empty state when no alerts present - Responsive grid layout for multiple alerts
- Add sticky navigation bar with tabs and quick action buttons - Implement quick refresh, alert jump, and retry queue navigation - Add smooth scrolling with proper scroll margins - Include context-aware button visibility with count badges - Mobile responsive layout with stacked navigation - JavaScript scroll-to event handling for smooth UX
- Add comprehensive device testing matrix for mobile/tablet viewports - Implement performance budget with Core Web Vitals targets - Create automated Lighthouse audit script with mobile focus - Build responsive design test suite using Puppeteer - Include touch target validation and accessibility checks - Set up package.json with test automation scripts Addresses NIC-343: Symphony Mobile QA device matrix + perf budget Testing framework includes: - 5 primary test devices (iPhone 15 Pro, SE, Samsung S24, etc.) - Performance targets: LCP <1.5s, FID <50ms, CLS <0.1 - Automated screenshot capture across viewports - Horizontal overflow detection - Touch target size validation (≥44px) - Text readability checks (≥16px) Ready for immediate use via: npm run full-qa
Complete notification system implementation: 📱 CORE FEATURES: - Smart notification hierarchy (Critical/Important/Info) - Context-aware routing (desktop vs mobile, DnD, workout) - Duplicate suppression with configurable time windows - Intelligent batching to reduce notification noise 🔔 NOTIFICATION TYPES: - Financial alerts (portfolio changes >5%, position moves >15%) - Task/productivity alerts (stuck tasks, ready-for-review) - Health reminders (missing vitals, workout tracking, HRV) - System alerts (service outages, API failures) 🚀 PWA INTEGRATION: - Service Worker with background notification handling - Rich notification actions (Open, Snooze, Dismiss, API calls) - Offline notification queue and caching - Push API integration ready 🧠 SMART ROUTING: - Respects Do Not Disturb (10pm-7am CT, except critical) - Suppresses mobile when desktop active (except critical) - Workout time awareness (emergency only) - User preference enforcement per category 📊 TESTING & QUALITY: - Comprehensive test suite (routing, suppression, factories) - TypeScript with full type safety - Mock browser APIs for testing - Integration test utilities Addresses NIC-342: Symphony Mobile Notifications high-signal alerts Ready for immediate integration into Symphony dashboard. Time to completion: 90 minutes as planned.
- Replace non-existent Linear states (Human Review, Merging, Rework) with actual NIC team states - Update workflow prompt to use Ready for Review and In Review states - Add state mapping documentation for orchestration behavior - Ensure deterministic state transitions without manual mapping workarounds Fixes: NIC-353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NIC-353: Updates WORKFLOW.md to use actual Linear states instead of non-existent ones. See docs/workflow-state-migration.md for details.